Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module to classpath on hdfs mode #1224

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mchataigner
Copy link

This fixes the missing libraries when running in hdfs mode.

@ianoc
Copy link
Collaborator

ianoc commented Mar 10, 2015

I think the notion is here is that jar mode is when you have a fat jar, which negates the notion of modules. looks like the hadoop_command is the one using lib jars. Can you give some context as to why that doesn't work and what this change is about?

@mchataigner
Copy link
Author

When you want to launch a remote repl on a hdfs cluster with avro module, you use:
./scripts/scald.rb -a --repl --hdfs --host HOST
but then you don't have avro module loaded by the repl.
Maybe there is another way to do it, but I am not very familiar with ruby.

And one other point would be to make possible to load external libraries other than scalding modules.

@ianoc
Copy link
Collaborator

ianoc commented Mar 11, 2015

Right that last part i'm not sure on, maybe the repl launch command is hitting the wrong method.

-- i.e. if you look at one method above the one you've been editing, the changes your trying to add are already in there, maybe the repl launch command should be calling down to it instead?

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mathieu Chataigner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants