Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added DELETE endpoint (https://dev.twitch.tv/docs/api/moderation/#del… #342

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

MrFastDie
Copy link

@MrFastDie MrFastDie commented Jul 16, 2023

…eting-chat-messages)

Proposed changes

Add the DELETE endpoint to the API

Types of changes

Added the DELETE endpoint to the API. Deleting chat messages is not supported by commands anymore (chat.delete command), so we should be able to use the API to delete those. https://dev.twitch.tv/docs/api/moderation/#deleting-chat-messages

  • New feature

Checklist

  • I have read the CONTRIBUTING.md doc
  • My PR is named according to CONTRIBUTING.md doc
  • End-to-end tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

No comments.

Copy link
Member

@marcandrews marcandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks great! I just left one comment. Let me know what you think.

yarn.lock Outdated Show resolved Hide resolved
@MrFastDie
Copy link
Author

Hey, this looks great! I just left one comment. Let me know what you think.

Hey @marcandrews could you rereview this? It would be nice having this as soon as possible in a new version on npm. Thanks ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants