Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: added TSDoc doc on Api.onAuthenticationFailure optional method #308

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

Fehniix
Copy link

@Fehniix Fehniix commented Jul 15, 2021

Proposed changes

Added TSDoc doc directly on the ApiOptions.onAuthenticationFailure method. Documentation on this project is amazing, it speeds up development by allowing to not go back and fourth from docs and IDE because it is readily provided TSDoc's. I felt like it was missing on the aforementioned method and thought I would add it.

Types of changes

  • [ x ] Chore

Checklist

  • [ x ] I have read the CONTRIBUTING.md doc
  • [ x ] My PR is named according to CONTRIBUTING.md doc
  • End-to-end tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [ x ] I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

No comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant