Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings to Twitter class #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ryuno-Ki
Copy link

@Ryuno-Ki Ryuno-Ki commented Mar 1, 2023

I reordered the methods with the public method that get called outside at the top and candidates for private methods below them.

A called method is placed below a calling method, which allows for drilling into implementation details the further down someone reads.

Caused #73 #74 #75 #76 #77 #78 #79 #80 #81 #82 #83 #84 as a result.

I reordered the methods with the public method that get called outside
at the top and candidates for private methods below them.

A called method is placed below a calling method, which allows for
drilling into implementation details the further down someone reads.

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
@nhoizey
Copy link
Contributor

nhoizey commented Mar 27, 2023

I'm sorry @Ryuno-Ki , I don't know how to check everything is right in your multiple PRs, I don't know if a build I would do with my own data would be enough. 😞

@zachleat any idea how to test all cases with this important refactoring?

@Ryuno-Ki
Copy link
Author

Almost three months in and still no feedback 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants