Correct minor typo #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just downloaded my archive and the first line of `tweets.js` is `window.YTD.tweets.part0 = [` not `window.YTD.tweet.part0 = [` as stated in the `README.md`
nhoizey
requested changes
Jan 12, 2023
| @@ -34,7 +34,7 @@ Take ownership of your Twitter data. First talked about at [Jamstack Conf 2019]( | |||
| ### Populate the database from your Twitter Archive zip | |||
|
|
|||
| 1. Copy `./data/tweets.js` from your [Twitter Archive](https://help.twitter.com/en/managing-your-account/how-to-download-your-twitter-archive) `zip` file into the `./database` directory of this project. | |||
| * Rename `window.YTD.tweet.part0` in `tweets.js` to `module.exports` | |||
| * Rename `window.YTD.tweets.part0` in `tweets.js` to `module.exports` | |||
There was a problem hiding this comment.
@popey could you add " (formerly window.YTD.tweet.part0)", as this is the name it had before?
There was a problem hiding this comment.
I forgot that there is already #47
So either change yours and I'll merge the first that is ready, or close this one as duplicate.
nhoizey
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just downloaded my archive and the first line of
tweets.jsiswindow.YTD.tweets.part0 = [notwindow.YTD.tweet.part0 = [as stated in theREADME.md