Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getImage private? #76

Open
Ryuno-Ki opened this issue Mar 1, 2023 · 0 comments
Open

Make getImage private? #76

Ryuno-Ki opened this issue Mar 1, 2023 · 0 comments

Comments

@Ryuno-Ki
Copy link

Ryuno-Ki commented Mar 1, 2023

Looking at

tweetback/src/twitter.js

Lines 153 to 158 in d03e289

async getImage(remoteImageUrl, alt) {
// TODO the await use here on eleventyImg could be improved
let stats = await eleventyImg(remoteImageUrl, ELEVENTY_IMG_OPTIONS);
let imgRef = stats.jpeg[0];
return `<a href="${imgRef.url}"><img src="${imgRef.url}" width="${imgRef.width}" height="${imgRef.height}" alt="${escapeAttribute(alt) || "oh my god twitter doesn’t include alt text from images in their API"}" class="tweet-media u-featured" onerror="fallbackMedia(this)" loading="lazy" decoding="async"></a>`;
}

it appears to be used only within this class. Therefore I suggest to declare it as a private method (by prefixing it with an underscore or using private class feature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant