Update Bazel to 6.4.0 #2063
Merged
Update Bazel to 6.4.0 #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
avdv
commented
Nov 30, 2023
avdv
commented
- update nixpkgs to nixos-23.11 which was released yesterday
- fix links in README and docs
- note that Bazel >= 6.0 is required in the README
avdv
force-pushed
the
upgrade-bazel-6.4.0
branch
from
2283d88
to
59a510e
Compare
|
It seems like the fix for NixOS/nixpkgs#269297 did not make it to the nixos-23.11 release and the nixpkgs CI jobs on Darwin fail with: This ☝️ is solved. Now, bazel_6 crashes on darwin: Here's the java crash file: https://gist.github.com/avdv/019d5453187daecf13819de1a3148d4d Note: created a new issue NixOS/nixpkgs#273745 |
avdv
force-pushed
the
upgrade-bazel-6.4.0
branch
2 times, most recently
from
d5c0b93
to
7c6c280
Compare
|
macos CI jobs are now failing with: which is related to #2070 |
avdv
force-pushed
the
upgrade-bazel-6.4.0
branch
from
1c3df86
to
80c8527
Compare
* users need Bazel >= 6.0 * replace old getting started link which redirects to the "Contributing to Bazel" page
- bump max Bazel version in start script - use Bazel 6.4.0 for integration tests - remove Bazel 6.2.0 from integration test
This avoids a SIGSEGV for bazel_6 from nixpkgs, see NixOS/nixpkgs#273745.
Downloading from https://hackage.haskell.org/ would otherwise fail with: ``` HttpExceptionRequest Request { host = "hackage.haskell.org" port = 443 secure = True requestHeaders = [("Accept-Encoding",""),("User-Agent","Haskell pantry package")] path = "/root.json" queryString = "" method = "GET" proxy = Nothing rawBody = False redirectCount = 10 responseTimeout = ResponseTimeoutDefault requestVersion = HTTP/1.1 proxySecureMode = ProxySecureWithConnect } (InternalException (HandshakeFailed (Error_Protocol "certificate rejected: security: createProcess: posix_spawnp: does not exist (No such file or directory)" CertificateUnknown))) ``` See commercialhaskell/stack#4558
When using nix we cannot use the system ar tool since it might have a different interface (ie. is assumed to support response files) than the nix provided one. The bintools packages provides `libtool` and `ar` in its `bin/` folder.
This avoids an error when compiling zlib with ISO C99 conforming compilers:
```
external/zlib.hs/gzwrite.c:78:20: error: call to undeclared function 'write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
writ = write(state->fd, strm->next_in, put);
^
external/zlib.hs/gzwrite.c:78:20: note: did you mean 'fwrite'?
/nix/store/51c1k4sj0irwgyvkgbyhqi0ggilyh3j2-Libsystem-1238.60.2/include/stdio.h:254:9: note: 'fwrite' declared here
size_t fwrite(const void * __restrict __ptr, size_t __size, size_t __nitems, FILE * __restrict __stream) __DARWIN_ALIAS(fwrite);
^
external/zlib.hs/gzwrite.c:108:24: error: call to undeclared function 'write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
writ = write(state->fd, state->x.next, put);
^
external/zlib.hs/gzwrite.c:627:9: error: call to undeclared function 'close'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (close(state->fd) == -1)
^
3 errors generated.
```
avdv
force-pushed
the
upgrade-bazel-6.4.0
branch
from
68b53fd
to
d927ace
Compare
```
clang: warning: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument]
tests/haskell_doctest/Bar.hs:11: failure in expression `bar'
expected: 9
but got: ld: warning: -undefined dynamic_lookup may not work with chained fixups
^
9
Examples: 3 Tried: 2 Errors: 0 Failures: 1
```
If the linker writes some output to stderr, this interferes with the expected output
in the doctest. Note, that if the linker fails, the output will be written to stdout/stderr
in any case.
avdv
force-pushed
the
upgrade-bazel-6.4.0
branch
from
d927ace
to
6e9f843
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.