Fixed "active" class bug with toggle within a segmented control body #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was a toggle element within a segmented control, they would all have their "active" class removed.
This reverts commit 790d530.
…(fixed older commit)
|
Hi @thewax , would you mind if I incorporate this PR into racthetPro? |
|
Absolutely!!! On Aug 10, 2016 9:30 PM, "Jim Ma" notifications@github.com wrote:
|
|
@thewax Pulled the code to RatchetPro: mazong1123@d24fe46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally made a pull request and completely screwed up the commit. Hopefully this is much clearer. It's a simple fix that more precisely specifies the CSS class in the queryselectors to prevent altering any other "active" CSS classes that may exist as child nodes, mainly the toggle switches.