Append content to DOM instead of setting innerHTML

Ensure that all bound events and data will remain attached to the element instead of "flattening" it to just HTML string.
twbs · Oct 13, 2014 · 1637b4f · 1637b4f
1 parent ab358dc
commit 1637b4f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/js/transitions.js b/js/transitions.js
@@ -39,7 +39,8 @@
 
   var displayBar = function (bar, container) {
     if (container) {
-      container.innerHTML = bar.innerHTML;
+      container.innerHTML = '';
+      container.appendChild(bar);
     } else {
       // per Ratchet's CSS, bar elements must be the first thing in <body>
       // here we assume `.content` is an immediate child of <body>
@@ -115,7 +116,8 @@
       transitionContent(newContentDiv, existingContentDiv,
                         transition, complete);
     } else {
-      document.body.innerHTML = contents.innerHTML;
+      document.body.innerHTML = '';
+      document.body.appendChild(contents);
       complete && complete();
     }
   };