Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Higher Google Lighthouse score with font-display: block #1010

Closed
paulalbertdev opened this issue Sep 10, 2021 · 0 comments · Fixed by #1312
Closed

Higher Google Lighthouse score with font-display: block #1010

paulalbertdev opened this issue Sep 10, 2021 · 0 comments · Fixed by #1312
Labels
bug Something isn't working
Projects
v1.8.2

Comments

@paulalbertdev
Copy link

Like it's described in this FontAwesome issue ( FortAwesome/Font-Awesome#16077 ) Google Loghthouse is giving a bad score since it doesn't know it's an icon font.

But it seems that adding "font-display: block" could solve this issue.

Thank a lot in advance for taking this request into account.
@paulalbertdev paulalbertdev added the bug Something isn't working label Sep 10, 2021
@mdo mdo mentioned this issue Oct 29, 2021
Closed
@mdo mdo added this to To do in v1.8.2 via automation May 10, 2022
mdo added a commit that referenced this issue May 10, 2022
@mdo
Fixes #1010: Add font-display: block
7eacdc6
@mdo mdo mentioned this issue May 10, 2022
Merged
@mdo mdo closed this as completed in #1312 May 13, 2022
v1.8.2 automation moved this from To do to Done May 13, 2022
mdo added a commit that referenced this issue May 13, 2022
@mdo
Fixes #1010: Add font-display: block
1007a03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
v1.8.2
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add font-display: block twbs/icons
1 participant
@paulalbertdev