Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font-display: block; to font-face #1066

Closed
edouardgat opened this issue Oct 29, 2021 · 1 comment
Closed

Add font-display: block; to font-face #1066

edouardgat opened this issue Oct 29, 2021 · 1 comment

Comments

@edouardgat
Copy link

edouardgat commented Oct 29, 2021

Font face declaration should implement font-display: block; to "ensure text remains visible during webfont load"

https://web.dev/font-display/#how-to-avoid-showing-invisible-text

(This issue is triggered in some Lighthouse or pagespeed benchmarks on any website using bootstrap icons font)

Thanks !

Edit: font-display: block; and not font-display: swap; as mentionned here : FortAwesome/Font-Awesome#14387

@edouardgat edouardgat changed the title Add font-display: swap; to font-face Add font-display: block; to font-face Oct 29, 2021
@mdo
Copy link
Member

mdo commented Oct 29, 2021

#1010

@mdo mdo closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants