Fix link decoration handling in Bootstrap SCSS files #39934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure lint passes. |
|
@mdo: this changes the look in many places, please have a look (see the docs preview for example). |
|
If it's going to be so big of a change, maybe we should postpone it until later. |
julien-deramond
requested changes
May 6, 2024
There was a problem hiding this comment.
Thanks for submitting a PR @layenis
I haven't looked at the changes in the code, but there's something off just by looking at the main page of our documentation:
These elements are not meant/designed to be underlined, and should stay as they were by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit refactors the handling of link decorations in _buttons.scss, _card.scss, _dropdown.scss, _list-group.scss, _nav.scss, _navbar.scss, _pagination.scss files. The
text-decorationproperty is now correctly applied based on the conditions specified by $link-decoration and $link-hover-decoration variables.Motivation & Context
This change is required to fix issues related to the handling of link decorations in Bootstrap SCSS files introduced by another fix.
The original implementation attempted to optimize the handling of link decorations by excluding the text-decoration property under specific conditions. However, this led to incorrect behavior due to incomplete consideration of all possible values for $link-decoration and $link-hover-decoration.
This fix addresses these issues by ensuring proper handling of the text-decoration property based on specified conditions. Specifically, it ensures that the text-decoration property is correctly applied according to the values of $link-decoration and $link-hover-decoration, thereby resolving visual inconsistencies or unexpected rendering of link decorations.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #39204