Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBE0055 Diabetes: Eye Exam #454

Merged
merged 25 commits into from May 14, 2024
Merged

CBE0055 Diabetes: Eye Exam #454

merged 25 commits into from May 14, 2024

Conversation

utsavpaudel
Copy link
Contributor

@utsavpaudel utsavpaudel commented May 3, 2024 •
edited by sarah-tuva

Describe your changes

CBE0055 Diabetes: Eye Exam Quality measure has been implemented as per the CMS document provided.

How has this been tested?

Measure output has been manually tested with the CMS document's logic. Denominator, Numerator, and Exclusion model's result has been validated as to where it's derived from.
Refer to the sheet for details.
https://docs.google.com/spreadsheets/d/1csJNaTf0lpEJxgQML8zVKHcDDlVoltynDPBAWZuH8Co/edit?usp=sharing

Reviewer focus

Please emphasize on the logic of retinopathy_last_year , no_retinopathy_last_year in the numerator model.
and diabetics_codes in the denominator model.

Checklist before requesting a review

  • I have updated the version number in dbt_project.yml file to reflect the release number of this PR
  • I have updated the docs files (by running dbt docs generate/serve and copying the necessary files into the docs folder)
  • I have commented my code as necessary
  • I have added at least one Github label to this PR
  • My code follows style guidelines
  • (Optional) I have recorded a Loom to explain this PR

(Optional) Gif of how this PR makes you feel

Loom link

Resolves #195

@utsavpaudel
untrack dbt_project.yml in integration_testing
159f48a
@utsavpaudel
revert deletion dbt_project
035b53f
@utsavpaudel
feat: CBE0055 performance period, deno, num, exclusions model
2f8c1e7
@utsavpaudel
Merge branch 'main' of https://github.com/utsavpaudel/tuva into diabe…
5cdcacc 
…tes-eye-exam
@utsavpaudel
docs: evidence_value added in 0053 numerator
561eb96
@utsavpaudel
docs: yml update for cbe0055
d5741da
@utsavpaudel
feat: long and final tables implementation cbe0055
e40cb01
@utsavpaudel
minor: comments removal
8f60c5b
@utsavpaudel
Merge branch 'main' of https://github.com/utsavpaudel/tuva into diabe…
709f334 
…tes-eye-exam
@utsavpaudel
minor: format changes
eedb515
@utsavpaudel
feat: numerator and denominator changes
208f323
@utsavpaudel
Merge branch 'main' of https://github.com/utsavpaudel/tuva into diabe…
3119edf 
…tes-eye-exam
@utsavpaudel
fix: numerator logic and yml fix
0b39552
@utsavpaudel
refactor: numerator retinopathy refactor
4a3cb32
@utsavpaudel
Merge pull request #1 from utsavpaudel/diabetes-eye-exam
56e3917 
CBE0055, Diabetes: Eye Exam
@utsavpaudel
feat: numerator refactor for ophthalm services
1926e16
@utsavpaudel
Merge pull request #2 from utsavpaudel/diabetes-eye-exam
eac786f 
feat: numerator refactor for ophthalm services
@utsavpaudel
Merge branch 'main' into main
9165907
@utsavpaudel
Merge branch 'main' into main
1f7075e
@sarah-tuva
Copy link
Member

Resolves #195

sarah-tuva
sarah-tuva requested changes May 9, 2024
View reviewed changes
Copy link
Member

@sarah-tuva sarah-tuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @utsavpaudel, I left a few requests for changes. Thank you so much for your work on this!

..._measures/intermediate/cbe0055_diabetes_eye_exam/quality_measures__int_cbe0055_numerator.sql Outdated Show resolved Hide resolved
..._measures/intermediate/cbe0055_diabetes_eye_exam/quality_measures__int_cbe0055_numerator.sql Outdated Show resolved Hide resolved
..._measures/intermediate/cbe0055_diabetes_eye_exam/quality_measures__int_cbe0055_numerator.sql Outdated Show resolved Hide resolved
...asures/intermediate/cbe0055_diabetes_eye_exam/quality_measures__int_cbe0055__denominator.sql Outdated Show resolved Hide resolved
...asures/intermediate/cbe0055_diabetes_eye_exam/quality_measures__int_cbe0055__denominator.sql Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Workflow has finished with the following statuses:

  • Snowflake: success
  • Snowflake: success
  • Snowflake: success
  • Redshift: success
  • Redshift: success
  • Redshift: success
  • BigQuery: success
  • BigQuery: success
  • BigQuery: success

@utsavpaudel
Copy link
Contributor Author

Hello @sarah-tuva, requested changes have been incorporated. Thank you for the suggestions.

@utsavpaudel
Copy link
Contributor Author

Hi @sarah-tuva, latest enhancement from #461 has uploaded all existing seed files into s3 and removed content from dbt.
Resolving merge conflicts, we also removed all the seeds for quality measures.
Looks like seeds for this measure has not yet been uploaded to S3, so please upload the seeds as necessary before merging this PR.
Thank you.

@sarah-tuva
Copy link
Member

Hi @sarah-tuva, latest enhancement from #461 has uploaded all existing seed files into s3 and removed content from dbt. Resolving merge conflicts, we also removed all the seeds for quality measures. Looks like seeds for this measure has not yet been uploaded to S3, so please upload the seeds as necessary before merging this PR. Thank you.

Good call out. Thanks @utsavpaudel! I'll work on this today and finalize the PR review/testing.

@sarah-tuva
Copy link
Member

@utsavpaudel I attempted to commit to your PR, but I don't think it worked. You'll need to update the dbt_project.yml file in the repo root with the S3 path of the upcoming version. I uploaded the latest version of the seeds to this path in S3: tuva-public-resources/versioned_value_sets/0.8.2

Here's what that will look like in your branch:
image

You can leave the other seeds as they are. We will create a separate PR updating the others when we are ready to create a new release. Let me know if you have questions about this. And thanks for bearing with us while we figure out this new workflow with versioned seeds.

@utsavpaudel
Copy link
Contributor Author

Hey @sarah-tuva, mentioned path has been updated. Please have a look again.

@github-actions GitHub Actions
Copy link

Workflow has finished with the following statuses:

  • Snowflake: success
  • Snowflake: success
  • Snowflake: success
  • Redshift: success
  • Redshift: success
  • Redshift: success
  • BigQuery: success
  • BigQuery: success
  • BigQuery: success

@sarah-tuva sarah-tuva merged commit 69adc0a into tuva-health:main May 14, 2024
@github-actions GitHub Actions
Copy link

Workflow has finished with the following statuses:

  • Snowflake: success
  • Snowflake: success
  • Snowflake: success
  • Redshift: failure
  • Redshift: skipped
  • Redshift: skipped
  • BigQuery: success
  • BigQuery: success
  • BigQuery: success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-tuva sarah-tuva sarah-tuva approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add measure: Diabetes - Eye Exam
2 participants
@utsavpaudel @sarah-tuva