Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AHRQ PQI measures #451

Merged
merged 16 commits into from May 15, 2024
Merged

AHRQ PQI measures #451

merged 16 commits into from May 15, 2024

Conversation

bradmontierth
Copy link
Contributor

Describe your changes

added AHRQ PQI measures

How has this been tested?

Ran on LDS 5% data and compared to published rates.

Reviewer focus

Tuva standards and practices that I am missing

Checklist before requesting a review

  • I have updated the version number in dbt_project.yml file to reflect the release number of this PR
  • I have updated the docs files (by running dbt docs generate/serve and copying the necessary files into the docs folder)
  • I have commented my code as necessary
  • I have added at least one Github label to this PR
  • My code follows style guidelines
  • (Optional) I have recorded a Loom to explain this PR

(Optional) Gif of how this PR makes you feel

Loom link

initial commit with pqis
moving to ahrq measures mart
@bradmontierth bradmontierth requested a review from thutuva May 1, 2024 01:07
Copy link
Member

@thutuva thutuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradmontierth - It's be great if you could make the following changes:

  • Create staging models for all tables that already exist in the Tuva Project.
    • Only have column in SELECT that are used in the data mart (no SELECT *)
  • Update the YAML file so all final tables have a list of column, their data type, and a description.

Copy link
Member

@thutuva thutuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thutuva thutuva merged commit 543d11e into main May 15, 2024
5 checks passed
@thutuva thutuva deleted the ahrq_measures branch May 15, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants