Updated approx_pos method in dataset.py #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ParsedDictionaryDefinitionDataset approx_pos method in dataset.py.
Something must've changed in how a
stanza.models.common.doc.Word
is structured, causing the methoddef approx_pos(cls, nlp, sentence, lookup_idx, lookup_len):
to fail.The Word object now looks something like:
The plus side of this is that the
start_char
andend_char
can now be extracted without using regex.I've tested the change in Google Colab.