bottomless2 boilerplate #1386
bottomless2 boilerplate #1386
Conversation
MarinPostma
force-pushed
the
bottomless-v2
branch
from
4be3a7e
to
d0eafc2
Compare
| @@ -0,0 +1,179 @@ | |||
| #![allow(dead_code, unused_variables, async_fn_in_trait)] | |||
There was a problem hiding this comment.
whats up with the async fn in trait stuff? Probably complaining about the send issues?
There was a problem hiding this comment.
linter complains because the trait is public API
| // job panicked. report and exit process. The program is crippled, from | ||
| // now on, so we just exit, and hope to restart on a fresh state. | ||
| tracing::error!("fatal error: bottomless job panicked: {e}"); | ||
| std::process::exit(1); |
There was a problem hiding this comment.
should we make this choice at a higher layer? Seems a bit extreme here to abort the whole process at a layer this deep.
There was a problem hiding this comment.
it's hard to trust higher level to abort the process if this task panics. The invariant here is that the task is not allowed to panic. it can error, but not panic. There's nothing much that the higher layer can do, the program is busted at this point. BTW, this is what assert should do: if you fail an assertion you exit the program.
| max_frame_no: u64, | ||
| } | ||
|
|
||
| pub trait Storage: Send + Sync { |
There was a problem hiding this comment.
I think we can use https://docs.rs/trait-variant/0.1.2/trait_variant/ to make the async fn sendable.
There was a problem hiding this comment.
we'll see it's that's necessary later
MarinPostma
force-pushed
the
bottomless-v2
branch
from
d0eafc2
to
00ba1ba
Compare
No description provided.