add session_token for AWS short-term credentials #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinassh
approved these changes
May 10, 2024
ryands17
force-pushed
the
bottomless/replicator-session-token
branch
2 times, most recently
from
634e685
to
5933a11
Compare
ryands17
force-pushed
the
bottomless/replicator-session-token
branch
from
5933a11
to
542a443
Compare
ryands17
force-pushed
the
bottomless/replicator-session-token
branch
from
542a443
to
4ba15c6
Compare
LucioFranco
approved these changes
May 29, 2024
|
@ryands17 thank you for your contribution! |
|
@ryands17 should be released in the latest sqld release,t hanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to use temporary credentials to backup the database to S3. The AWS_SESSION_TOKEN can be optionally passed in to use temporary credentials locally or in an environment like EC2/EKS where roles are attached to the instance.
@avinassh Created a new PR as the old one had some problems with squashing commits.