add query timing #1370
Open
add query timing #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haaawk
reviewed
May 3, 2024
| @@ -446,7 +446,7 @@ pub unsafe extern "C" fn libsql_execute_stmt( | |||
| set_err_msg(format!("Error executing statement: {}", e), out_err_msg); | |||
| 2 | |||
| } | |||
| } | |||
| }let end_time = start_time.elapsed(); | |||
There was a problem hiding this comment.
I don't think this will compile.
haaawk
reviewed
May 3, 2024
| let conn = conn.get_ref(); | ||
| match RT.block_on(conn.query(sql, ())) { | ||
| Ok(rows) => { | ||
| let end_time = start_time.elapsed(); // Calculate elapsed time | ||
| println!("Query execution time: {:?}", end_time); |
There was a problem hiding this comment.
It is a bad practise to print like that in libraries. Please use tracing instead.
haaawk
reviewed
May 3, 2024
| let rows = Box::leak(Box::new(libsql_rows { result: rows })); | ||
| *out_rows = libsql_rows_t::from(rows); | ||
| } | ||
| Err(e) => { | ||
| let end_time = start_time.elapsed(); // Calculate elapsed time | ||
| println!("Query execution failed. Time elapsed: {:?}", end_time); |
There was a problem hiding this comment.
It is a bad practise to print like that in libraries. Please use tracing instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to the project, if i made some mistake please guide me.