Jw/custom headers in auth #1271
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-passing-and-auth
* server: fix interactive txn schema panic * fix txn check * fix check errors * Apply suggestions from code review --------- Co-authored-by: ad hoc <postma.marin@protonmail.com>
Don't build inside the source tree because `cargo clean` won't clean up after it...
* server: add shutdown timeout * add config cli/env var for timeout * wire timeout
…1256) allow explain queries without bind parameters In SQLite, it is invalid to pass a query with a ? or named parameter without a bind variable, unless you are just trying to explain the command. We always fail those queries, but we shouldn't.
…ly equivalent to the previous form. No change in logic.
…ly equivalent to the previous form. No change in logic.
…1275) * Stop expiring connections in replication hyper client Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com> * Remove keep-alive Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com> --------- Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
We have a user with a failing snapshot, but we don't know why. We know rename returns EINVAL, which could happen for a variety of reasons, all of them related to the paths themselves. By printing the path, we will be able to figure out the actual reason. Right now we're shooting in the dark.
Make CC and CXX configurable for the build process. Allows us to, for example, make sure we're building with just clang on macOS.
* add malformed db test * continue to debug output sql * reduce sql * reset connection on injection * remove println in test * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
every UserAuthStrategy now needs to also implement required_fields()
the caller is expected to make best effort to provide these headers, but it is not guaranteed
it is up to the UserAuthStrategy how to act in case of missing or malformed fields