Página de doadores #400
Open
Página de doadores #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berinhard
requested changes
Sep 9, 2020
This was referenced Sep 9, 2020
marcmatias
force-pushed
the
marcmatias/donators_apoiase
branch
from
798e1c9
to
1f0437c
Compare
marcmatias
force-pushed
the
marcmatias/donators_apoiase
branch
from
1f0437c
to
d035c85
Compare
berinhard
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
A solução do solr-thumbnail funcionou de boas. As imagens ficaram um pouco pixeladas, mas acho que tá bem tranquilo.
Percebi as requisições do scroll também tomaram mais tempo para terminarem. Acredito que isso seja por conta do processamento dos thumbnails mesmo. Seria bom, depois de deployarmos isso para prod, forçar o scroll até o limite para pré-processar as imagens dos perfis existentes até o momento.
Não entendi porque o lint parece estar quebrando para 80 linhas ao invés das 120 definidas no Makefile. @turicas se não achar problemático, por mim faz o merge e acerta o lint num outro commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposta é exibir os doadores com um infinite-scroll.
Este PR mescla características dos PRs: #377 e #307