WIP Refatora estatísticas covid19 para usar queryset #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berinhard
reviewed
Sep 9, 2020
berinhard
reviewed
Sep 9, 2020
Comment on lines
+58
to
+70
| @property | ||
| def number_of_cities_with_cases(self): | ||
| return self.get_queryset().latest_city_cases().count() | ||
|
|
||
| @property | ||
| def number_of_cities_with_deaths(self): | ||
| return self.get_queryset().latest_city_cases().with_deaths().count() | ||
|
|
||
| @property | ||
| def affected_population(self): | ||
| return ( | ||
| self.get_queryset().latest_city_cases().aggregate(population=Sum("estimated_population_2019"))["population"] | ||
| ) |
There was a problem hiding this comment.
Acho que vale a pena adicionarmos testes para essas métricas, não? Sei que esse não é o foco do trabalho agora, mas assim como fizemos com os dynamic models com issue #396, me parece que aqui também vale uma issue lembrete dos testes uma hora que tenhamos esse PR mergeado
berinhard
force-pushed
the
enhancement/covid19-qs-stats
branch
from
f40c0f8
to
503900c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.