-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prvocisla #231
base: master
Are you sure you want to change the base?
Prvocisla #231
Conversation
Vymazanie vzorového súboru 'example.py'
Vloženie hlavného programu
Odstránenie zvyšných errorov a warningov cez flake8
Test pre funkciu 'prvocislo' s testovacími hodnotami do 1000
Test pre funkciu 'prvocislo_mr' s hodnotami väčšími ako 1000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- v Actions zrušte workflow pages-build-deployment (nastavit disable vpravo nahoře pod tlačítkem [...] zde: https://github.com/Cvachtacik/vs_project/actions/workflows/pages/pages-build-deployment)
- soubory main.py, test_prvocislo.py a test_pvocislo_mr.py přesunout do kořenového adresáře
- zrušit adresáře Prvočísla a PyDOC a docs včetně obsahu
- smazat soubory .DS_Store a main.html
- main.py upravit takto:
Dokumentácia html vygenerovaná pomocou pdoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- testy už fungují, ještě vyčistit kód, aby prošel přes statickou analýzu nástrojem flake8 viz chyby zde: https://github.com/Cvachtacik/vs_project/actions/runs/4029052153/jobs/6926551827
- v Actions zrušte spouštění workflow pages-build-deployment (nastavit disable vpravo nahoře pod tlačítkem [...] zde: https://github.com/Cvachtacik/vs_project/actions/workflows/pages/pages-build-deployment)
- odstranit adresáře .pytest_cache a docs včetně obsahu
Úprava kódu main.py, test_prvocislo.py a test_prvocislo_mr.py tak, aby vyhovoval testu Flake8
…into Prvocisla
Vymazanie adresárov .pytest_cache a docs
test_prvocislo.py
Outdated
def test_prvocislo(self): | ||
self.assertFalse(prvocislo(1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def test_prvocislo(self): | |
self.assertFalse(prvocislo(1)) | |
def test_prvocislo(): | |
assert prvocislo(1) is False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- v Actions opětovně povolit pouštění workflow Python checker(https://github.com/Cvachtacik/vs_project/actions/workflows/python_checker.yml) a naopak zrušit pouštění workflow pages-build-deployment (nastavit disable vpravo nahoře pod tlačítkem [...] zde: https://github.com/Cvachtacik/vs_project/actions/workflows/pages/pages-build-deployment)
- opravit kód tak, aby prošel přes workflow Python checker, tzn včetně flake8
Povolené púšťanie workflow Python checker, ale u pages-build-deployment nemám možnosť pre disable viz tu: |
Úprava komentárov, aby vyhovovali pre flake8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ještě poslední drobnosti, stejně doplnit u funkce prvocislo_mr.
Posledné drobnosti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poslední drobnost
Posledné úpravy
No description provided.