Projekt na prvočíslo #221
Open
Projekt na prvočíslo #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracovní verze projektu, ještě bude updatenuto.
Partially commented - please finish the function comments including their variables
# Conflicts: # projekt.py
Obě metody jsou dle mého deterministické,.. přehozeny funkce, aby u čísel větších než 100 byla použita početní metoda a ne metoda síta. lehký edit komentářů.
linted via Flake8
turecekt
requested changes
Dec 8, 2022
aplikován commit suggestion pro změnu podle vašeho návrhu. Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
turecekt
requested changes
Jan 15, 2023
There was a problem hiding this comment.
Stále neprochází pytest: https://github.com/konj27/vs_project/actions
protože nejsou přijety změny z upstream repozitáře.
[8 commits behind turecekt:master
Partially commented - please finish the function comments including their variables
|
Opraveno, pytest i flake8 prochází, dokumentace vygenerována |
turecekt
requested changes
Jan 23, 2023
There was a problem hiding this comment.
- ještě upravit docstring modulu projekt na víceřádkový (viz code review) a aktualizovat jeho obsah (timetracker není implementován) - stejně v readme.md
- v sekci About na hlavní stránce repa upravit Website url na url vašich gh-pages s vygenerovanou dokumentací
projekt.py
Outdated
Comment on lines
1
to
5
| """Test for primality.""" | ||
|
|
||
| import math | ||
|
|
||
| """This file consists of two methods for determination of primality |
There was a problem hiding this comment.
Suggested change
| """Test for primality.""" | |
| import math | |
| """This file consists of two methods for determination of primality | |
| """Test for primality. | |
| This file consists of two methods for determination of primality |
Update podle suggestions Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
turecekt
requested changes
Jan 25, 2023
|
flake 8 prochází. změna about you sekce aby zobrazovala odkaz na náš profil místo tagu. |
turecekt
requested changes
Jan 25, 2023
There was a problem hiding this comment.
- ještě drobnost ohledně typů parametrů v docstringu, pdoc neumí všechny direktivy reST, takže datové typy raději umístit jako type hints viz code review
- v popisu modulu projekt a i v README.md máte stále popis této vlastnosti ikdyž není implementována: "Simple timetracker is included for performance measuring.Python time library is used." - odstranit
- zde(https://github.com/konj27/vs_project) v pravém sloupci nahoře doplní vlastník repozitáře Website url na url s vygenerovanou dokumentaci v Github Pages z Action deploy, tzn na tuto hodnotu: https://konj27.github.io/vs_project/
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
turecekt
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spolupracovali:
Jan Koňařík
Martin Stříteský
Erik Jukin
Michal Vašíček