-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compatibility with multiphase solvers #349
base: master
Are you sure you want to change the base?
Conversation
For multiphase simulations, the user must specify two new coefficients: 'multiPhase' (bool, true means multi-phase solver is used) and 'phaseName' (word, only needed if multiPhase is true, should correspond to the main phase name - usually air- as defined in the 'transportProperties' dictionary). This is done to pick the correct value for kinematic viscosity.
Is this actually necessary to define in the |
Sorry, I think that I was not clear enough about the purpose of the commit. The goal is to access the kinematic viscosity which will then be used to compute the Reynolds number in Of course, I would also prefer the user not to have to define this in |
It sounds like it should be possible. |
My apologies, I did not know about Travis CI at all and to be honest, neither was I following OF's style guidelines. Do you think this style guide from openfoam.org suffices? |
The built-in formatter in VS Code may do the trick: https://code.visualstudio.com/docs/cpp/cpp-ide#:~:text=The%20C%2FC%2B%2B%20extension%20for%20Visual%20Studio%20Code%20supports%20source,in%20right%2Dclick%20context%20menu. Otherwise, the error messages give the instructions: Lines should be shorter than 80 characters and |
For multiphase simulations, the user must specify two new coefficients: 'multiPhase' (bool, true means multi-phase solver is used) and 'phaseName' (word, only needed if multiPhase is true, should correspond to the main phase name - usually air- as defined in the 'transportProperties' dictionary). This is done to pick the correct value for kinematic viscosity.
This commit is meant to serve as the initial commit for a 'floatingTurbine' branch. As part of my MSc thesis, some modifications are made to the original library to make it compatible with the 6-DoF motion characterizing floating wind turbines (FWTs). The final goal is that the AL turbine can be used in multiphase simulations, where waves2Foam will be used for wave generation and absorption. Both libraries need to be coupled together and, at the same time, to the rigid body solver for the floating turbine motion. The tool resulting from the project should have the potential to be validated and expanded to serve as a reliable technique for the advanced modelling of FWTs.