Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AoA circle calc only needs to be defined in a blade subDict #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petebachant
Copy link
Collaborator

@petebachant petebachant commented Nov 29, 2017

Similar to other parameters such as end effects correction, this should probably go in the individual blade dictionaries, which are easily copied to others using macro substitution.

Then again, flow curvature and dynamic stall are defined at the turbine level, so maybe the AL sample radius and points should be as well.

@petebachant
Copy link
Collaborator Author

@andersgoude can you check out this branch and give it a test?

A reminder in case you haven't done this yet:

git remote add upstream https://github.com/turbinesFoam/turbinesFoam.git
git fetch upstream
git checkout aoa-circle-blade-dict

@andersgoude
Copy link
Contributor

The modifications work. You can go ahead and merge this

@petebachant
Copy link
Collaborator Author

Thanks for testing. I may have changed my mind on this, that you had it right the first time, and that this should be defined on a turbine level (as it is on the master branch now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants