Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query adapter to easy compatibility with various drivers and implement Mysql adapter #363

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

caioreix
Copy link

@caioreix caioreix commented Mar 21, 2023

This pull request adds a new layer to the queries which will enable easy compatibility with various drivers.

@caioreix caioreix changed the title Quey adapter Query adapter to easy compatibility with various drivers and implement Mysql adapter Mar 21, 2023
@caioreix caioreix closed this Mar 21, 2023
@caioreix caioreix deleted the quey-adapter branch March 21, 2023 17:16
@caioreix caioreix restored the quey-adapter branch March 21, 2023 20:19
@caioreix caioreix reopened this Mar 21, 2023
@ahmedRSA
Copy link

ahmedRSA commented Apr 1, 2023

Amazing work, i wonder why tulir haven't merged this yet?

@caioreix
Copy link
Author

caioreix commented May 2, 2023

Hello @tulir! Do you have any suggestions or complaints about this pull request? I believe it would be very useful in the main branch, as it gives users the freedom to choose/implement their preferred driver for the package.

@caioreix
Copy link
Author

caioreix commented May 3, 2023

If this is related to MySQL query maintenance, I suggest creating a discussion and storing the implementation of the driver there. This would eliminate the need for you to update the MySQL queries, while also providing an easy way for the community to utilize them. I would be grateful if you could provide me with a feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants