Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scheme test actions parallelizable #6112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pepicrft
Copy link
Contributor

Short description 馃摑

I'm enabling parallelization in the project schemes. I guess that it'll cause some flakiness because we have a bunch of shared states around that might leak across tests. If that's the case, it validates that we should invest in a solution like context to control the isolation of the subject under tests.

@pepicrft pepicrft self-assigned this Mar 25, 2024
@pepicrft pepicrft requested review from a team, fortmarek and kwridan and removed request for a team March 25, 2024 03:21
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to skip parallelization of test cases that interact with the simulator. Otherwise, as long as the tests pass, this looks good 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants