Skip flagging the install error if there's no instance of external dependency in the graph #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaicris-adoreme
changed the title
…-error-with-no-external-dependencies-in-the-graph
…-no-external-dependencies-in-the-graph' of github.com:mihaicris-adoreme/tuist into feature/TUIST-6053-skip-flagging-the-install-error-with-no-external-dependencies-in-the-graph
danieleformichelli
approved these changes
Mar 10, 2024
…-error-with-no-external-dependencies-in-the-graph
…ip-flagging-the-install-error-with-no-external-dependencies-in-the-graph
pepicrft
added
the
changelog:fixed
pepicrft
approved these changes
Mar 12, 2024
…-error-with-no-external-dependencies-in-the-graph
…p-flagging-the-install-error-with-no-external-dependencies-in-the-graph
…p-flagging-the-install-error-with-no-external-dependencies-in-the-graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6053
Short description 📝
Skip flagging the install error if there's no instance of external dependency in the graph
How to test the changes locally 🧐
Have a project with dependencies integrated by Xcode, but also Package.json defined for external dependencis.
Project should be able to be generated without tuist install for fetching dependencies
Contributor checklist ✅
mise run lint:fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry