[Multiplatform] Migrate ProjectDescription.Target to support multiple platforms
#5595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltflanagan
changed the title
ProjectDescription.Target to support multiple platforms
waltflanagan
changed the title
ProjectDescription.Target to support multiple platformsProjectDescription.Target to support multiple platforms
waltflanagan
force-pushed
the
multi-platform/GraphEdges
branch
from
bcb639a
to
15c5268
Compare
waltflanagan
force-pushed
the
multi-platform/FinalInterface
branch
from
f9daf51
to
1a9cc40
Compare
kwridan
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Awesome, thanks for the all the updates @waltflanagan 👍
The introduction of Condition and CombinationResults makes things a lot more clearer and easier to follow
I retested the changes against our project and looks like there are no diffs / regressions 🎉
I believe all my feedback points from #5557 (review) have been addressed, thanks again!
6 tasks
waltflanagan
force-pushed
the
multi-platform/GraphEdges
branch
from
15c5268
to
842c4a6
Compare
This covers two scenarios Apply platform filters to transitive dependencies if they exist in intermediate steps Given: A -> (.ios) B and B -> C Then: A -> (.ios) C Remove dependencies if intermediate filters result in a disjoint set Given: A -> (.ios) B and B -> (.macos) C Then: A -> C should have `nil` platform filters, which results it it being removed as a transitive dependency.
…`test` and `build`
…ight `PlatformFilters`
waltflanagan
force-pushed
the
multi-platform/FinalInterface
branch
from
1a9cc40
to
0fa3a5b
Compare
This just resolves like any other multiplatform target now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very first exposure of multiplatform work in ProjectDescription. All feedback on API design welcome.
Addresses #5515
Short description 📝
Complete adding support for multiple platform targets in Tuist by exposing the API in
ProjectDescription.TargetIn order to minimize disruption and maintain source compatibility, we will deprecate the single platform
initin preference ofinit(destinations:deploymentTargets:). We expose an analog ofPlatformandDeploymentTargetfor source compatibility but they should no longer be relied upon.To support multiplatform targets, we also migrate SPM dependencies via
Dependencies.swiftto use multiplatform targets instead of the single platformFramework_iospatterns.When generating the resulting
xcodeproj, platform filters are applied toPBXBuildFileinstances viaLinkGeneratorHow to test the changes locally 🧐
Run tests. All should pass.
Contributor checklist ✅
make workspace/lint-fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry