-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro support via Dependencies.swift #5587
Conversation
59dc6a4
to
0c16654
Compare
869b3cb
to
f1c9f39
Compare
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
1a9cc40
to
0fa3a5b
Compare
b4b28b9
to
ccda481
Compare
7b761fc
to
b126dc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bump TCA dependency in app_with_spm_dependencies
fixture to make sure it compiles fine? π
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniele Formichelli <df@bendingspoons.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
As @danyf90, it would be great to bump the TCA to make sure that dependency builds π
Resolves #5488
Short description π
This allows non-macos targets to depend on packages that provide macros.
How to test the changes locally π§
Run
fetch
andgenerate
against the fixtureframework_with_swift_macro
. Framework should build when depending on packages that provide macros viaDependencies.swift
Contributor checklist β
make workspace/lint-fix
Reviewer checklist β
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry