Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro support via Dependencies.swift #5587

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Conversation

waltflanagan
Copy link
Member

@waltflanagan waltflanagan commented Nov 17, 2023

Resolves #5488

Short description πŸ“

This allows non-macos targets to depend on packages that provide macros.

How to test the changes locally 🧐

Run fetch and generate against the fixture framework_with_swift_macro. Framework should build when depending on packages that provide macros via Dependencies.swift

Contributor checklist βœ…

  • The code has been linted using run make workspace/lint-fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@waltflanagan waltflanagan changed the base branch from multi-platform/Phase3 to multi-platform/FinalInterface November 21, 2023 00:32
@waltflanagan waltflanagan force-pushed the multi-platform/FinalInterface branch 2 times, most recently from 1a9cc40 to 0fa3a5b Compare November 27, 2023 22:38
Base automatically changed from multi-platform/FinalInterface to main November 28, 2023 15:36
@waltflanagan waltflanagan changed the title Prototype Macro support in multiplatform world Multi-platform macros support Nov 28, 2023
@waltflanagan waltflanagan changed the title Multi-platform macros support Macro support via Dependencies.swift Nov 28, 2023
@waltflanagan waltflanagan marked this pull request as ready for review November 28, 2023 17:52
Copy link
Collaborator

@danieleformichelli danieleformichelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump TCA dependency in app_with_spm_dependencies fixture to make sure it compiles fine? πŸ™

Co-authored-by: Daniele Formichelli <df@bendingspoons.com>
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

As @danyf90, it would be great to bump the TCA to make sure that dependency builds 😌

@waltflanagan waltflanagan merged commit 492cee9 into main Nov 29, 2023
27 checks passed
@waltflanagan waltflanagan deleted the multi-platform/Macros branch November 29, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing support for SwiftPackageManager macros
3 participants