Fix caching tuist #5585
Merged
Fix caching tuist #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
force-pushed
the
fix/tuist-meta-cache
branch
from
7e2bb9d
to
c6dfa9c
Compare
danieleformichelli
approved these changes
Nov 16, 2023
fortmarek
force-pushed
the
fix/tuist-meta-cache
branch
from
e4bfa3e
to
981478c
Compare
pepicrft
reviewed
Nov 17, 2023
| @@ -29,6 +29,10 @@ func targets() -> [Target] { | |||
| .target(name: "TuistKit"), | |||
| .target(name: "ProjectDescription"), | |||
| .target(name: "ProjectAutomation"), | |||
| .external(name: "SwiftToolsSupport"), | |||
There was a problem hiding this comment.
Were we importing those in code without explicitly declaring them here? I wonder if we can do something to prevent these things again.
There was a problem hiding this comment.
I wonder if we can do something to prevent these things again.
We could scan for import XXX statements. Not sure if there's a better way 🤔
pepicrft
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Brilliant work @fortmarek 👏🏼. Dog-fooding is critical to keep improving Tuist and Tuist Cloud
fortmarek
force-pushed
the
fix/tuist-meta-cache
branch
4 times, most recently
from
143b249
to
e706599
Compare
fortmarek
force-pushed
the
fix/tuist-meta-cache
branch
from
e706599
to
f73e228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
This PR does two things:
tuistproject definition, so replacing individual binaries works correctlycache warmboth for Sillicon and Intel machinestuist testshould now reuse these binaries when available, making those tests fasterThe only downside of these changes is that now we have lots of warnings that dependencies are imported by multiple targets. We should follow up on this PR and make it possible to selectively disable this warning for frameworks where you know duplicated symbols won't cause issues.
How to test the changes locally 🧐
tuistTuist Cloud instance, runtuist generate tuist-> you should be able to run the CLI with the downloaded binaries.Contributor checklist ✅
make workspace/lint-fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry