Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to symlink Package.swift to Tuist/Package.swift #5562

Closed
wants to merge 5 commits into from

Conversation

danieleformichelli
Copy link
Collaborator

No description provided.

}
try fileHandler.write(content, path: packageManifestPath, atomically: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we skip the process of writing another Package.swift?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, if we want SPM resolution and folders to be created in Tuist/Dependencies/SwiftPackageManager, then the Package should be located there.
It's more conveniente for those to be in a separate folder, so you can just gitignore the whole Tuist/Dependencies/SwiftPackageManager

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be Tuist/Dependencies/SwiftPackageManager? We adopted that structure because we supported multiple package managers so I'm wondering if we should simplify things a bit and stick to SPM's convention.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having everything in Tuist/ would be strange I think. Anyway, it would be a breaking change and in case it would go in 4.0

@danieleformichelli danieleformichelli changed the title Symlink Package.swift to Tuist/Package.swift Allow to symlink Package.swift to Tuist/Package.swift Nov 19, 2023
@danieleformichelli
Copy link
Collaborator Author

Closing this, I'll rather add a config to specify the location of the Package.swift

@danieleformichelli danieleformichelli deleted the chore/link-package-swift branch November 20, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants