Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source file filtering logic to filter out paths that are directories. #6198

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kyounh12
Copy link

@kyounh12 kyounh12 commented Apr 16, 2024

Resolves #6186

Short description πŸ“

Add an extra check to filter out paths that are directories (but not with a source compatible extension) when filtering source file paths.
This prevents directories with name ends with extension like .Swift being considered as source files.

How to test the changes locally 🧐

  1. Add ApprovalTest.Swift package in Tuist/Package.swift
.package(url: "https://github.com/approvals/ApprovalTests.Swift.git", branch: "master")
  1. Add ApprovalTest.Swift as an external dependency to one of project targets.
  2. Run tuist install
  3. Run tuist generate

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@kyounh12 kyounh12 marked this pull request as draft April 16, 2024 15:13
@kyounh12 kyounh12 marked this pull request as ready for review April 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant