Skip isFolder check for some extensions to improve performance

tuist · Apr 16, 2024 · c32ca41 · c32ca41
1 parent c750e2d
commit c32ca41
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/Sources/TuistCore/Graph/ModelExtensions/Target+Core.swift b/Sources/TuistCore/Graph/ModelExtensions/Target+Core.swift
@@ -83,13 +83,16 @@ extension Target {
                 .subtracting(excluded)
                 .filter { path in
                     guard let `extension` = path.extension else { return false }
-
-                    if FileHandler.shared.isFolder(path) {
-                        // If path points to a directory, we need to check if extension is source compatible.
-                        return Target.validSourceCompatibleFolderExtensions
-                            .contains(where: { $0.caseInsensitiveCompare(`extension`) == .orderedSame })
+
+                    let hasValidSourceExtensions = Target.validSourceExtensions
+                        .contains(where: { $0.caseInsensitiveCompare(`extension`) == .orderedSame })
+
+                    if hasValidSourceExtensions {
+                        // Addition check to prevent folders with name like `Foo.Swift` to be considered as source files.
+                        return !FileHandler.shared.isFolder(path)
                     } else {
-                        return Target.validSourceExtensions
+                        // There are extensions should be considered as source files even if they are folders.
+                        return Target.validSourceCompatibleFolderExtensions
                             .contains(where: { $0.caseInsensitiveCompare(`extension`) == .orderedSame })
                     }
                 }