New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding plusplus #16
base: master
Are you sure you want to change the base?
Adding plusplus #16
Conversation
@@ -1,13 +1,13 @@ | |||
// Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just delete this whole file.
Looks like its working on my local hubot with a redis server running. I'm sure theres a way to keep the words more persistant, but I'll have to go learn them. |
/** | ||
* -- - Decrement points of target | ||
* */ | ||
robot.respond('/(.*)\\\-\\\-/', function (msg) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be robot.hear
instead of robot.respond
. The reason is that respond requires @owlbot
at the head of the message. We want to be able to bill++
without @owlbot bill++
The concolusion of each ++/-- should also end with owlbot returning the current score for a specific item.
This is good. I did find a possible edge case? Not sure.
I would probably look at the existing codebase https://github.com/ajacksified/hubot-plusplus/blob/master/src/plusplus.coffee and only modify it with the timeout stuff that you have added. |
Adds plusplus commands to owlbot. The commands are responses, so they must follow an 'owlbot' or 'Owlbot'. The increment and decrement commands are rate limited. Right now the limit is 5 seconds.
Commands Added: