Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use size_t instead of uint8_t for sysex length #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phjanderson
Copy link

The size of a sysex message should be typed size_t instead of uint8 to allow longer sysex messages. Currently increasing SYSEX_BUFFER_SIZE in Settings.hpp does not work as expected, changing the length type to size_t solves the problem and allows handling larger sysex messages.

The size of a sysex message should be typed size_t instead of uint8 to allow longer sysex messages. Currently increasing SYSEX_BUFFER_SIZE in Settings.hpp does not work as expected, changing the length type to size_t solves the problem and allows handling larger sysex messages.
@tttapa
Copy link
Owner

tttapa commented Dec 31, 2020

This has been addressed on the new-input feature branch that will eventually become version 2.0 when I have more time.

I think 64 KiB should be enough to cover most use cases. The new-input branch also supports chunked SysEx messages, so you don't need a large buffer to be able to receive (or send) huge messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants