Make sure ArResolver works for other adapter with proxy #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsukasaoishi can you please review this. |
untwal
force-pushed
the
protected/resolver/prepend
branch
from
fb009aa
to
f462315
Compare
untwal
changed the title
untwal
force-pushed
the
protected/resolver/prepend
branch
from
f462315
to
66bc23f
Compare
tsukasaoishi
reviewed
Mar 3, 2021
| base_adapter_name = "#{specification.config[:adapter].to_s}_adapter".camelize | ||
| __extend_adapter_by_fc( | ||
| "::ActiveRecord::ConnectionAdapters::#{base_adapter_name}".constantize, | ||
| OtherAdapterProxy |
There was a problem hiding this comment.
I'd like to be able to specify an extend module(like OtherAdapterProxy) in a configurations.
example:
config/initializers/fresh_connection.rb
FreshConnection.extend_adapter_proxy = OtherAdapterProxyCould you to be able to add a function like above?
If it seems difficult for you, I will implement it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve this, other adapters need some proxy which might not be the primary one.