Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This adapter('redshift') is not supported. If you specified the mysql or postgres adapter, it's probably a bug in FreshConnection #38

Open
untwal opened this issue Feb 23, 2021 · 1 comment · May be fixed by #39
Open

This adapter('redshift') is not supported. If you specified the mysql or postgres adapter, it's probably a bug in FreshConnection #38

untwal opened this issue Feb 23, 2021 · 1 comment · May be fixed by #39

Comments

@untwal
Copy link

untwal commented Feb 23, 2021 •
edited

rails: 5.1.7

fresh_connection is being reviewed by us, for the purpose of PostgreSQL read-replica usage in our project, currently, we are using activerecord5-redshift-adapter also in the project. While this activerecord5-redshift-adapter also use the ActiveRecord::ConnectionAdapters::ConnectionSpecification::Resolver following prepend is limiting us from using the same in our project. I am willing to make changes to the ArResolver Class.

Please let me know your thoughts on the same.
@untwal untwal linked a pull request Feb 24, 2021 that will close this issue
Open
@tsukasaoishi
Copy link
Owner

tsukasaoishi commented Mar 3, 2021 •
edited

Thank you for your pull request.
I have no time to correspond all activerecord adapters.
Your proposal is good idea.
I commented your pull request.
#39 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure ArResolver works for other adapter with proxy untwal/fresh_connection
2 participants
@tsukasaoishi @untwal