Update README.md #75
Annotations
1 error and 20 warnings
Clippy
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy@master, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy:
kaitai-macros/src/hir/attr.rs#L271
warning: iterating on a map's values
--> kaitai-macros/src/hir/attr.rs:271:32
|
271 | cases: cases.into_iter().map(|(_k, _v)| todo!()).collect(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cases.into_values().map(|_v| /* body */)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `#[warn(clippy::iter_kv_map)]` on by default
|
Clippy:
kaitai-macros/src/hir/attr.rs#L349
warning: the borrowed expression implements the required traits
--> kaitai-macros/src/hir/attr.rs:349:55
|
349 | en: en.map(|id| Ident::new(&sc_to_ucc(&id), Span::call_site())),
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
Clippy:
kaitai-macros/src/hir/attr.rs#L271
warning: iterating on a map's values
--> kaitai-macros/src/hir/attr.rs:271:32
|
271 | cases: cases.into_iter().map(|(_k, _v)| todo!()).collect(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cases.into_values().map(|_v| /* body */)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `#[warn(clippy::iter_kv_map)]` on by default
|
Clippy:
kaitai-macros/src/hir/doc.rs#L91
warning: use of `format!` to build up a string from an iterator
--> kaitai-macros/src/hir/doc.rs:91:5
|
91 | iter.into_iter().map(|i| format!("- {}\n", i)).collect()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: call `fold` instead
--> kaitai-macros/src/hir/doc.rs:91:22
|
91 | iter.into_iter().map(|i| format!("- {}\n", i)).collect()
| ^^^
help: ... and use the `write!` macro here
--> kaitai-macros/src/hir/doc.rs:91:30
|
91 | iter.into_iter().map(|i| format!("- {}\n", i)).collect()
| ^^^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `#[warn(clippy::format_collect)]` on by default
|
Clippy:
kaitai-macros/src/hir/en.rs#L15
warning: the borrowed expression implements the required traits
--> kaitai-macros/src/hir/en.rs:15:42
|
15 | ident: Ident::new(&sc_to_ucc(&id), Span::call_site()),
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
Clippy:
kaitai-macros/src/hir/en.rs#L21
warning: the borrowed expression implements the required traits
--> kaitai-macros/src/hir/en.rs:21:50
|
21 | ident: Ident::new(&sc_to_ucc(&id), Span::call_site()),
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
Clippy:
kaitai-macros/src/hir/attr.rs#L349
warning: the borrowed expression implements the required traits
--> kaitai-macros/src/hir/attr.rs:349:55
|
349 | en: en.map(|id| Ident::new(&sc_to_ucc(&id), Span::call_site())),
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
Clippy:
kaitai-macros/src/hir/ty.rs#L41
warning: the borrowed expression implements the required traits
--> kaitai-macros/src/hir/ty.rs:41:49
|
41 | .map(|id| Ident::new(&sc_to_ucc(&id), Span::call_site()))
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
Clippy:
kaitai-macros/src/hir/ty.rs#L72
warning: the borrowed expression implements the required traits
--> kaitai-macros/src/hir/ty.rs:72:53
|
72 | id: Some((Ident::new(&sc_to_ucc(&id), Span::call_site()), false)),
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
Clippy:
kaitai-macros/src/hir/attr.rs#L507
warning: useless use of `vec!`
--> kaitai-macros/src/hir/attr.rs:507:9
|
507 | vec!["bitch", "dont", "kill", "my", "vibe"]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["bitch", "dont", "kill", "my", "vibe"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
|