sec(Home) Reflected XSS via stuffid/stufftype parameters

tsolucio · Aug 24, 2022 · 537c117 · 537c117
1 parent 5f5594f
commit 537c117
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/Home/NewBlock.php b/modules/Home/NewBlock.php
@@ -14,8 +14,8 @@
 require_once 'include/home.php';
 require_once 'Smarty_setup.php';
 
-$stuffid = vtlib_purify($_REQUEST['stuffid']);
-$stufftype = vtlib_purify($_REQUEST['stufftype']);
+$stuffid = filter_var($_REQUEST['stuffid'], FILTER_SANITIZE_NUMBER_INT);
+$stufftype = urlencode(vtlib_purify($_REQUEST['stufftype']));
 
 $homeObj=new Homestuff();
 $smarty=new vtigerCRM_Smarty;