Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPAN compliant and TAP compliant 馃巵 #404

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lskatz
Copy link

@lskatz lskatz commented Aug 8, 2019

I created a Makefile.PL so that Prokka is CPAN-compliant. This also makes things more streamlined in Travis-CI.

  • Added minimal documentation in prokka.
  • Added Makefile.PL which describes modules used among many other things.
  • Added MANIFEST for make dist, if you decide to upload to cpan.
  • Moved tests to t/05_prokka.t which is invoked with make test or perl t/05_prokka.t.
    • Any future unit tests can be created in t/ and will be run in alphanumeric order. I chose to start the unit test script with 05 in case there were a future test that should be run before this one.
  • Replaced one instance of sed with pure perl to help with error checking and/or any issues with subshells at that stage.

All tests defined by @tseemann pass in travis-ci.

@mr-c
Copy link

mr-c commented Dec 15, 2019

Would be great to see Prokka in CPAN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants