-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to the Tru API for working with large databases #848 #939
base: main
Are you sure you want to change the base?
Conversation
Thanks @priyalorha ! It looks like the tests are failing here because of some incorrect imports: Can you adjust these? For example: can be adjusted to: |
Hi; can you add abstract definitions of the new methods to db.py class DB ? |
@ellipsis-dev can you add tests and documentation for this change? |
hi @joshreini1 - apologies for delay in Ellipsis response, issues with our LLM provider. We're finding a workaround. (Automated summaries and reviews should still be operational) |
Thanks for the update @nsbradford ! |
|
||
return data | ||
|
||
def get_record_and_feedback(self, record_id) -> [pd.DataFrame]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the return type correct?
Thanks for the abstract definitions. A few smaller things:
|
Formatting ./trulens_eval |
You can install these with pip. |
@priyalorha were you able to successfully use these new methods? I was only able to successfully run Ran into various errors using:
To this end, it would be helpful to add usage examples to the docstrings for these methods and additional typing for the method arguments |
nope, I was unable to set this up. Can you send me the error so that I can
fix them
…On Tue, 5 Mar 2024 at 2:41 AM, Josh Reini ***@***.***> wrote:
@priyalorha <https://github.com/priyalorha> were you able to successfully
use these new methods? I was only able to successfully run
tru.get_record_and_feedback.
Ran into various errors using:
- tru.list_records
- tru.delete_record
- tru.delete_app
—
Reply to this email directly, view it on GitHub
<#939 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI6R4KJQVVBWI7XUYZZTDFLYWTPQ5AVCNFSM6AAAAABD3CCDOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGQ3DENJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Seeing the following errors: For all three methods, I'm seeing: |
I have updated the query both fetch should work fine, I have my doubts on delete , can you provide me with instructions on how to build and use this library? |
You can install from your branch with the below code (also in README):
|
issue #848