Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] add otel semantic convention attributes #1124

Merged
merged 53 commits into from
May 29, 2024

Conversation

piotrm0
Copy link
Contributor

@piotrm0 piotrm0 commented May 3, 2024

  • Added more information to design.md and split of internal discussions into internals.md. Included the secondary goal of the external API's in design.md.

  • Added a temporary file (not currently used) with span features that are part of open telemetry semantic conventions for AI as seen here: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/llm-spans.md and here https://github.com/traceloop/openllmetry/blob/main/packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv/ai/__init__.py .

  • Renamed some json-related type aliases and started using typing_extensions.TypeAliasType.

  • Also renamed a few type aliases to conform to TCamelCase naming scheme.

  • Added a tool component to custom app example that records the stack trace when it is invoked. This is for demonstration purposes of the library internals with regards to instrumentation.

  • Added a component which uses trulens recording contexts itself. This is also for demonstration purposes.

  • Moved a few attributes from Span class to its parent OTSpan. These are things close enough to things in the OTEL spec that they would belong better there.

  • Started work on otel compatible exporter with the method OTSpan.freeze which produces an OTEL ReadableSpan.

  • Prototyping storage and querying of JSON in sqlalchemy-managed databases.

joshreini1 and others added 3 commits May 1, 2024 12:49
* azureopenai docstring

* azureopenai.md

* remove extra references to supported feedbacks

* Update azureopenai.md
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 3, 2024
@piotrm0 piotrm0 marked this pull request as draft May 3, 2024 20:49
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

timbmg and others added 23 commits May 7, 2024 11:38
Co-authored-by: Josh Reini <60949774+joshreini1@users.noreply.github.com>
* fix link on langchain instrumentation docs

* fix llama-index quickstart link

* fix langchain instrumentation docs, add missing imports

* add missing imports to nemo instrumentation docs
* fix rag triad and awaitable calls

* remove locals printout in awaitables message
…ses, added trulens internals demonstrations notebook
* fix rag triad and awaitable calls

* remove locals printout in awaitables message

* update __getattr__ in select_context (#1119)

---------

Co-authored-by: Piotr Mardziel <piotrm@gmail.com>
Co-authored-by: Josh Reini <60949774+joshreini1@users.noreply.github.com>
* Update feedback.py

* use name
retreivers -> retrievers
* unify groundedness start

* remove groundedness.py

* groundedness nli moves

* remove custom aggregator

* groundedness aggregator to user code

* move agg to trulens side by default (groundedness)

* remove extra code

* remove hf key setting

* remove hf import

* add comment about aggregation for context relevance

* update init

* remove unneeded import

* use generate_score_and_reasons for groundedness internally

* f-strings for groundedness prompts

* docstring

* docstrings formatting

* groundedness reasons template

* remove redundant prompt

* update quickstarts

* llama-index notebooks

* rag triad helper update

* oai assistant nb

* update readme

* models notebooks updates

* iterate nbs

* mongo, pinecone nbs

* update huggingface docstring

* remove outdated docstring selector notes

* more docstring cleaning
* open ai streaming adjustments in cost tracking

* notes

* delete outputs
Co-authored-by: joshreini1 <joshreini1@users.noreply.github.com>
Co-authored-by: Josh Reini <60949774+joshreini1@users.noreply.github.com>
* Update selecting_components.md

* Update MultiQueryRetrievalLangchain.ipynb

* Update random_evaluation.ipynb

* Update canopy_quickstart.ipynb
piotrm0 and others added 9 commits May 16, 2024 11:08
* update comprehensiveness + nb

* nb expansion

* fix typo

* meetingbank transcript data

* oss models in app

* test

* benchmarking gpt-3.5-turbo, gpt-4-turbo, and gpt-4o

* update path

* comprehensiveness benchmark

* updated summarization_eval nb

* fix normalization

* show improvement in comprehensiveness feedback functions

---------

Co-authored-by: Daniel <dah0417912@gmail.com>
* version bump

* simpler lc quickstart

* update installs and imports

* update langchain instrumentation docs

* remove groundedness ref from providers.md

* build docs fixes

* remove key cell

* fix docs build

* firx formatting for stock.md

* remove extra spaces

* undo format change

* update docstrings for hugs and base provider

* openai docstring updates

* hugs docstring update

* update context relevance hugs docstring

* more docstring updates

* remove can be changed messages from openai provider docstrings
Co-authored-by: joshreini1 <joshreini1@users.noreply.github.com>
* add to glossary

* finish some terms
@piotrm0 piotrm0 marked this pull request as ready for review May 20, 2024 18:08
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. documentation Improvements or additions to documentation and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 20, 2024
@piotrm0 piotrm0 requested a review from walnutdust May 20, 2024 18:12
piotrm0 and others added 15 commits May 20, 2024 12:05
* add httpx to requirements

* undo httpx add

* test add langchain-community

* change langchain-community required version
…nai endpoint (#1154)

* first

* adjust docs

* logic

* add langhain_community to pinecone reqs too

* adjust trubot example with new reqs

* more reqs

* remove extra text

* add langchain_community to a few imports in notebooks

---------

Co-authored-by: Piotr Mardziel <piotrm@Piotrs-Laptop.local>
Co-authored-by: Josh Reini <60949774+joshreini1@users.noreply.github.com>
Co-authored-by: Josh Reini <joshua.reini@snowflake.com>
Co-authored-by: Josh Reini <joshua.reini@snowflake.com>
@piotrm0 piotrm0 merged commit dbe8af4 into feature/traces May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants