NAS-128386 / 24.10 / Port WidgetNetworkComponent to new dashboard

[denysbutenko]

Check network widget at new dashboard

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128386

[codecov]

Codecov Report

Attention: Patch coverage is 65.97222% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 73.67%. Comparing base (6a42c77) to head (ab9ba50).
Report is 1 commits behind head on master.

Files	Patch %	Lines
...network/widget-network/widget-network.component.ts	77.10%	19 Missing ⚠️
...ets/network/widget-network/widget-network.utils.ts	44.11%	19 Missing ⚠️
...ges/dashboard/services/widget-resources.service.ts	33.33%	10 Missing ⚠️
...rc/app/pages/dashboard/services/dashboard.store.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10014      +/-   ##
==========================================
+ Coverage   73.65%   73.67%   +0.02%     
==========================================
  Files        1505     1509       +4     
  Lines       52924    53032     +108     
  Branches     6329     6342      +13     
==========================================
+ Hits        38980    39071      +91     
- Misses      13944    13961      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RehanY147]

Don't think this will work when interfaceName is null/empty string. string is passed by value so that variable will never update and this observable will keep skipping emits because of the skipWhile.
Also, I think computing time values on the spot are a better approach. We don't need this information all the time. Just when making the calls. Why keep timers on when they are not needed.

[denysbutenko]

Yeah, that's right. It looks like leftover since we are switching to networkInterfaceUpdate once the interface is loaded

[RehanY147]

We should break this large object down into smaller chunks stored in variables with declarative names so it's more readable what we're doing.

[denysbutenko]

It sounded like a good idea at first. When I did, it became less readable, and understanding what and where became more complex. So, I prefer to keep it as is.

Here is what it might look like after splitting:

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.