Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128689 / 24.10 / Fix layout preview issues for WidgetGroupFormComponent #10013

Merged
merged 1 commit into from May 2, 2024

Conversation

RehanY147
Copy link
Contributor

Go to the WidgetGroupForm on the new dashboard and switch between different possible layouts.
on master, the preview doesn't update properly. This PR fixes that.

@RehanY147 RehanY147 requested a review from a team as a code owner May 1, 2024 12:54
@RehanY147 RehanY147 requested review from AlexKarpov98 and removed request for a team May 1, 2024 12:54
@bugclerk bugclerk changed the title NAS-128689: Fix layout preview issues for WidgetGroupFormComponent NAS-128689 / 24.10 / Fix layout preview issues for WidgetGroupFormComponent May 1, 2024
@bugclerk
Copy link
Contributor

bugclerk commented May 1, 2024

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (ad58f09) to head (a08a6ea).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10013   +/-   ##
=======================================
  Coverage   73.50%   73.50%           
=======================================
  Files        1501     1501           
  Lines       52696    52696           
  Branches     6298     6298           
=======================================
  Hits        38736    38736           
  Misses      13960    13960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now.
The only thing we can fix - is a background color of an empty element, white is not good.

Screen.Recording.2024-05-01.at.18.36.59.mov

@RehanY147
Copy link
Contributor Author

I can fix that in a separate PR.

@RehanY147 RehanY147 merged commit c90ab57 into master May 2, 2024
10 checks passed
@RehanY147 RehanY147 deleted the NAS-128689 branch May 2, 2024 00:21
@bugclerk
Copy link
Contributor

bugclerk commented May 2, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants