Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128688 / 24.10 / Dashboard state is reverted once I saved, switched page and returned #10012

Merged
merged 1 commit into from May 2, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket & result 👇

Screen.Recording.2024-05-01.at.13.17.50.mov

@AlexKarpov98 AlexKarpov98 self-assigned this May 1, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner May 1, 2024 10:26
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team May 1, 2024 10:26
@bugclerk bugclerk changed the title NAS-128688: Dashboard state is reverted once I saved, switched page and returned NAS-128688 / 24.10 / Dashboard state is reverted once I saved, switched page and returned May 1, 2024
@bugclerk
Copy link
Contributor

bugclerk commented May 1, 2024

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.50%. Comparing base (ad58f09) to head (79d17c2).

Files Patch % Lines
src/app/services/auth/auth.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10012      +/-   ##
==========================================
- Coverage   73.50%   73.50%   -0.01%     
==========================================
  Files        1501     1501              
  Lines       52696    52699       +3     
  Branches     6298     6298              
==========================================
- Hits        38736    38734       -2     
- Misses      13960    13965       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good!

@AlexKarpov98 AlexKarpov98 merged commit aadaf61 into master May 2, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128688 branch May 2, 2024 08:02
@bugclerk
Copy link
Contributor

bugclerk commented May 2, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants