New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-128385 / 24.10 / Port CPU widget to new dashboard #10004
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10004 +/- ##
==========================================
+ Coverage 73.57% 73.61% +0.03%
==========================================
Files 1504 1506 +2
Lines 52660 52769 +109
Branches 6292 6310 +18
==========================================
+ Hits 38745 38846 +101
- Misses 13915 13923 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The CPU widget is showing up on the new dashboard.
import { AppState } from 'app/store'; | ||
import { waitForSystemInfo } from 'app/store/system-info/system-info.selectors'; | ||
|
||
interface CpuParams { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interface shouldn't be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bvasilenko - please update https://github.com/truenas/webui/pull/10009/files#diff-30b70af9b0d2da808112496b0366f5db251fefc62238f754f8bb8d4637cffeceR111 - to include this widget as well.
This PR has been merged and conversations have been locked. |
Testing
Verify widget at the new dashboard