Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128385 / 24.10 / Port CPU widget to new dashboard #10004

Merged
merged 6 commits into from May 3, 2024
Merged

Conversation

bvasilenko
Copy link
Contributor

Testing

Verify widget at the new dashboard

@bvasilenko bvasilenko requested a review from a team as a code owner April 28, 2024 19:20
@bvasilenko bvasilenko requested review from RehanY147 and removed request for a team April 28, 2024 19:20
@bugclerk bugclerk changed the title Port CPU widget to new dashboard NAS-128385 / 24.10 / Port CPU widget to new dashboard Apr 28, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 93.26923% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.61%. Comparing base (c90ab57) to head (7c22573).
Report is 2 commits behind head on master.

Files Patch % Lines
...ard/widgets/cpu/widget-cpu/widget-cpu.component.ts 93.68% 6 Missing ⚠️
...rc/app/pages/dashboard/services/dashboard.store.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10004      +/-   ##
==========================================
+ Coverage   73.57%   73.61%   +0.03%     
==========================================
  Files        1504     1506       +2     
  Lines       52660    52769     +109     
  Branches     6292     6310      +18     
==========================================
+ Hits        38745    38846     +101     
- Misses      13915    13923       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The CPU widget is showing up on the new dashboard.

import { AppState } from 'app/store';
import { waitForSystemInfo } from 'app/store/system-info/system-info.selectors';

interface CpuParams {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface shouldn't be here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvasilenko bvasilenko merged commit b59d1fa into master May 3, 2024
10 checks passed
@bvasilenko bvasilenko deleted the NAS-128385 branch May 3, 2024 14:34
@bugclerk
Copy link
Contributor

bugclerk commented May 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants