Added list collections api #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods in base class for the same, updated deepdoctection library and modified dockerfile for pytorch
akashg3627
reviewed
May 16, 2024
| @@ -201,6 +201,10 @@ def get_collections(self) -> List[Collection]: | |||
| collection = Collection.parse_obj(self._get_entity_from_run(run=ml_run)) | |||
| collections.append(self._polulate_collection(collection)) | |||
| logger.debug(f"[Metadata Store] Listed {len(collections)} collections") | |||
| end = time.time() | |||
| print( | |||
There was a problem hiding this comment.
should we remove this now?
akashg3627
reviewed
May 16, 2024
| "type": run_params.get("data_source_fqn").split("::")[0], | ||
| "uri": run_params.get("data_source_fqn").split("::")[1], | ||
| "fqn": run_params.get("data_source_fqn"), | ||
| "metadata": run_params.get("metadata", {}), |
There was a problem hiding this comment.
this metadata field will never be presend, so you can remove that
akashg3627
reviewed
May 16, 2024
| @@ -9,13 +9,11 @@ | |||
|
|
|||
|
|
|||
| @router.get("/") | |||
| def list_data_source(): | |||
| async def list_data_source(): | |||
There was a problem hiding this comment.
you will need complete details api too
There was a problem hiding this comment.
So, better expose this as new api
akashg3627
reviewed
May 16, 2024
backend/server/routers/collection.py
Outdated
| @@ -35,6 +35,16 @@ def get_collections(): | |||
| raise HTTPException(status_code=500, detail=str(exp)) | |||
|
|
|||
|
|
|||
| @router.get("/list-collections") | |||
There was a problem hiding this comment.
Suggested change
| @router.get("/list-collections") | |
| @router.get("/list") |
akashg3627
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.