Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): request body read multiple times #5660

Closed
wants to merge 2 commits into from

Conversation

KATT
Copy link
Member

@KATT KATT commented Apr 21, 2024

Closes #5659

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

βœ… Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@KATT KATT requested a review from a team as a code owner April 21, 2024 23:03
Copy link

Diagnostics Comparison

Numbers

Metric PR next
Files 795 795 (βž– 0)
Lines of Library 40,640 40,640 (βž– 0)
Lines of Definitions 118,098 118,098 (βž– 0)
Lines of TypeScript 4,967 4,967 (βž– 0)
Lines of JavaScript 0 0 (βž– 0)
Lines of JSON 0 0 (βž– 0)
Lines of Other 0 0 (βž– 0)
Identifiers 174,966 174,966 (βž– 0)
Symbols 109,035 109,035 (βž– 0)
Types 89 89 (βž– 0)
Instantiations 0 0 (βž– 0)
Memory used 175,734 174,800 (πŸ”Ί 934)
Assignability cache size 0 0 (βž– 0)
Identity cache size 0 0 (βž– 0)
Subtype cache size 0 0 (βž– 0)
Strict subtype cache size 0 0 (βž– 0)

Timings and averages

Metric PR next
max (s) 4.47 4.111 (πŸ”Ί 0.36)
min (s) 4.47 4.111 (πŸ”Ί 0.36)
avg (s) 4.47 4.111 (πŸ”Ί 0.36)
median (s) 4.47 4.111 (πŸ”Ί 0.36)
length 1 1 (βž– 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.04 0.04 (βž– 0)
Parse time 0.72 0.69 (πŸ”Ί 0.03)
ResolveTypeReference time 0.03 0.03 (βž– 0)
ResolveModule time 0.11 0.1 (πŸ”Ί 0.01)
ResolveLibrary time 0.02 0.02 (βž– 0)
Program time 1.06 1 (πŸ”Ί 0.06)
Bind time 0.43 0.43 (βž– 0)
Total time 1.49 1.43 (πŸ”Ί 0.06)

@KATT KATT changed the title Issues/5659 multi body read fix(server): request body read multiple times Apr 21, 2024
@KATT KATT closed this in #5661 Apr 21, 2024
Copy link

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: request body read multiple times
1 participant