feat: support formdata in fetch adapter #5649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @juliusmarminge and the rest of your teammates on |
Diagnostics ComparisonNumbers
Timings and averages
unstable timingsUnstable
|
juliusmarminge
force-pushed
the
fetch-adapter-formdata
branch
from
4b77a70
to
07f219a
Compare
juliusmarminge
commented
Apr 20, 2024
examples/bun/src/client.ts
Outdated
Comment on lines
51
to
54
| const form = new FormData(); | ||
| form.append('foo', 'bar'); | ||
| const postFormData = await proxy.formData.mutate(form); | ||
| console.log('formData reponse', postFormData); |
KATT
approved these changes
Apr 21, 2024
| .input(z.instanceof(FormData)) | ||
| .mutation(({ input }) => { | ||
| const object = {} as Record<string, unknown>; | ||
| input.forEach((value, key) => (object[key] = value)); |
There was a problem hiding this comment.
You can do some Object.fromEntries-thing here
There was a problem hiding this comment.
It's a copy-pasta from Nicks vanilla router
| @@ -244,6 +256,26 @@ describe('with default server', () => { | |||
|
|
|||
| await client.foo.query(); | |||
| }); | |||
|
|
|||
| // Miniflare seems broken. Working test in examples/bun | |||
There was a problem hiding this comment.
Could you elaborate on this comment a bit?
There was a problem hiding this comment.
Test failed when it shouldn't
|
This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5648
🎯 Changes
What changes are made in this PR? Is it a feature or a bug fix?
FormDatasupport in fetch adapterRequestgeneric since most frameworks has their own extended type that sets some extra properties on top of the standard✅ Checklist